Skip to content

fix(integration): Fix filename validation to compare with PR base SHA instead of latest branch#658

Merged
HC-kang merged 1 commit intoDaleStudy:mainfrom
HC-kang:integration-hotfix
Dec 9, 2024
Merged

fix(integration): Fix filename validation to compare with PR base SHA instead of latest branch#658
HC-kang merged 1 commit intoDaleStudy:mainfrom
HC-kang:integration-hotfix

Conversation

@HC-kang
Copy link
Copy Markdown
Contributor

@HC-kang HC-kang commented Dec 9, 2024

μΆ”κ°€λœ νŒŒμΌμ„ ν™•μΈν•˜κΈ° μœ„ν•΄ diff ν•  λ•Œ, μžμ‹ μ˜ λΆ€λͺ¨κ°€ μ•„λ‹ˆλΌ μ΅œμ‹  λΈŒλžœμΉ˜μ™€ λΉ„κ΅ν•˜κ³  μžˆμ—ˆμŠ΅λ‹ˆλ‹€.
μ΄λ‘œμΈν•΄ 쀑간에 λˆ„κ΅°κ°€ λ‹€λ₯Έ λ©€λ²„λΆ„κ»˜μ„œ λ¨Έμ§€ν•˜μ‹œλŠ” 경우, 톡합할 수 μ—†λŠ” μƒνƒœκ°€ λ˜κ³ μžˆμ—ˆλ„€μš”.

@HC-kang HC-kang requested a review from a team as a code owner December 9, 2024 10:42
@HC-kang HC-kang requested review from DaleSeo, EgonD3V and obzva and removed request for a team December 9, 2024 10:43
@HC-kang HC-kang force-pushed the integration-hotfix branch from f750a0b to 596e53a Compare December 9, 2024 11:50
@HC-kang HC-kang changed the title fix(integration): Fix filename validation to handle deleted/updated files in PR fix(integration): Fix filename validation to compare with PR base SHA instead of latest branch Dec 9, 2024
Copy link
Copy Markdown
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λΉ λ₯Έ 쑰치 κ°μ‚¬ν•©λ‹ˆλ‹€!

@HC-kang HC-kang merged commit d975b97 into DaleStudy:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants