Skip to content

[beta] Python Profiling support#244

Merged
astuyve merged 25 commits intomainfrom
aj/profiling-poc
Aug 23, 2022
Merged

[beta] Python Profiling support#244
astuyve merged 25 commits intomainfrom
aj/profiling-poc

Conversation

@astuyve
Copy link
Copy Markdown
Contributor

@astuyve astuyve commented Aug 23, 2022 •
edited
Loading

What does this PR do?

This PR enables the (beta) use of the new serverless profiling capabilities of ddtrace-py in Lambda.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner August 23, 2022 14:06
maxday
maxday reviewed Aug 23, 2022
View reviewed changes
maxday
maxday reviewed Aug 23, 2022
View reviewed changes
@astuyve astuyve requested a review from maxday August 23, 2022 17:32
maxday
maxday approved these changes Aug 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@maxday maxday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! do we want to build and release this layer in sandbox to see the impact on cold start (when profiling is disabled) since the package size has grown a bit?

@astuyve
Copy link
Copy Markdown
Contributor Author

astuyve commented Aug 23, 2022 •
edited
Loading

LGTM! do we want to build and release this layer in sandbox to see the impact on cold start (when profiling is disabled) since the package size has grown a bit?

We've got a release on sandbox already, will test a cold start version shortly

@astuyve
Copy link
Copy Markdown
Contributor Author

astuyve commented Aug 23, 2022

We ran three versions of the same handler code (simple hello world).

  • without-profiling (version 60 of this library, no profiler code at all)
  • with profiling (pre-release of 61 of this library, which imports the profiler and turns it on)
  • with profiling but disabled (pre-release of 61 of this library, which has the larger filesize compared to without-profiling)

With profiling packaged and enabled, we see ~200ish ms cold start increase.
We see almost no cold start increase for including profiling, but not loading that code.
image
image

@astuyve astuyve merged commit 96eecdc into main Aug 23, 2022
@astuyve astuyve deleted the aj/profiling-poc branch August 23, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maxday maxday maxday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@astuyve @maxday