Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 72 72
Lines 3804 3804
=======================================
Hits 3601 3601
Misses 203 203 ☔ View full report in Codecov by Sentry. |
pablomartinezbernardo
approved these changes
Sep 16, 2024
Contributor
pablomartinezbernardo
left a comment
There was a problem hiding this comment.
IMO 1.0.0
Adhering to the meaning of major, minor and patch gives some meanings to the version, unlike the classical definition of "major changes" for major versions.
zacharycmontoya
approved these changes
Sep 17, 2024
Contributor
zacharycmontoya
left a comment
There was a problem hiding this comment.
LGTM, 1.0.0 sounds appropriate to me given the breaking API changes
4afcba5 to
47c8104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our next release will be
v1.0.0as part of our adherence to semantic versioning (semver). While there are no major changes, commits 32f0338 and d354e96 introduced some API changes that are not backward-compatible.Note to reviewers
v1.0.0orv0.3.0? You decide.