fix: Apply "version" tag only when the span service name matches the default service name#157
Merged
zacharycmontoya merged 3 commits intomainfrom Oct 7, 2024
Conversation
BenchmarksBenchmark execution time: 2024-10-06 15:23:53 Comparing candidate commit ba34e04 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 72 72
Lines 3804 3808 +4
=======================================
+ Hits 3601 3605 +4
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ice name that does not match the tracer default, then no "version" tag is added
…a span only if its service name matches the default service name Issues: APMAPI-517
dad1df2 to
c544d03
Compare
- Make the logic used to apply `version` tag more explicit. - Removed unused variable in test.
dmehala
approved these changes
Oct 6, 2024
Collaborator
dmehala
left a comment
There was a problem hiding this comment.
LGTM 
I briefly updated the span_data.cpp to make the logic more explicit/easier to comprehend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply version tag to a span only if its service name matches the default service name. This may be viewed as a breaking change since now some spans that are started with a new service name will not have the "version" tag set.
Motivation
This behavior conforms to our Config Consistency initiative
Additional Notes
As this may be breaking, we could put this new behavior behind a feature flag, but I'm inclined to say that this is a FIX rather than a FEATURE.
Jira ticket: APMAPI-517