feat!: Change default value of DD_TRACE_RATE_LIMIT to 100#159
Merged
zacharycmontoya merged 1 commit intomainfrom Oct 7, 2024
Merged
feat!: Change default value of DD_TRACE_RATE_LIMIT to 100#159zacharycmontoya merged 1 commit intomainfrom
zacharycmontoya merged 1 commit intomainfrom
Conversation
…ault value of DD_TRACE_RATE_LIMIT to 100 Issues: APMAPI-511
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 72 72
Lines 3804 3804
=======================================
Hits 3601 3601
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmehala
approved these changes
Oct 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the default value of DD_TRACE_RATE_LIMIT to 100 (previously 200)
Motivation
This aligns the cpp tracer behavior for an unconfigured
DD_TRACE_RATE_LIMITwith the expected behavior of all the tracers in our Config Consistency initiative.Additional Notes
This is technically a breaking change as some users may observe traces being limited. We may consider this more of a FIX or we can put this behind a feature flag. Thoughts?
Jira ticket: APMAPI-511