build: do not FetchContent nlohmann_json if already found by find_package#227
Closed
sjanel wants to merge 1 commit intoDataDog:mainfrom
Closed
build: do not FetchContent nlohmann_json if already found by find_package#227sjanel wants to merge 1 commit intoDataDog:mainfrom
FetchContent nlohmann_json if already found by find_package#227sjanel wants to merge 1 commit intoDataDog:mainfrom
Conversation
dmehala
reviewed
Aug 5, 2025
Contributor
dmehala
left a comment
There was a problem hiding this comment.
Thanks for your contribution @sjanel.
While I'm not opposed to avoiding the download of nlohmann-json if it's already installed on the system, we should ensure that the installed version matches the required one to prevent potential compilation errors.
FetchContent nlohmann_json if already found by find_package
FetchContent nlohmann_json if already found by find_packageFetchContent nlohmann_json if already found by find_package
FetchContent nlohmann_json if already found by find_packageFetchContent nlohmann_json if already found by find_package
Contributor
Author
To ensure a minimum version is found, we can do something like: |
dmehala
reviewed
Aug 13, 2025
dmehala
reviewed
Aug 14, 2025
710ce93 to
0964486
Compare
0964486 to
864c854
Compare
dmehala
approved these changes
Aug 14, 2025
Contributor
dmehala
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your contribution 🙇
Contributor
|
Slight details, @sjanel can you sign your commit? please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it possible to use
dd-trace-cppas a dependency when nlohmann_json has already been fetched content by a project.It also renames
jsonintonlohmann_jsonas it is more standard in other projects.Motivation
Additional Notes
Bump version of
nlohmann_jsonto 3.12.0.Jira ticket: [PROJ-IDENT]