Replace Abseil extension with bazel_dep and eliminate source patching#243
Merged
dmehala merged 2 commits intoDataDog:mainfrom Sep 14, 2025
Merged
Replace Abseil extension with bazel_dep and eliminate source patching#243dmehala merged 2 commits intoDataDog:mainfrom
dmehala merged 2 commits intoDataDog:mainfrom
Conversation
bfd06f9 to
831fc52
Compare
831fc52 to
c970a3a
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
c970a3a to
5a7ea9e
Compare
dmehala
approved these changes
Sep 14, 2025
Collaborator
dmehala
left a comment
There was a problem hiding this comment.
Thanks for your contribution. LGTM ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the request to modernize the Abseil dependency management by replacing the custom Bazel extension with a standard
bazel_depand eliminating the need for source patching.Problem
The current setup used a custom Bazel extension (
extensions.bzl) to download Abseil viahttp_archiveand apply a source patch (abseil.patch) to modifyabsl/base/options.h. The patch forced Abseil to not use C++ standard library types:This approach had several downsides:
Solution
1. Replaced extension with direct bazel_dep
2. Replaced patch with compile-time configuration
Instead of patching source files, the same behavior is achieved through C++ preprocessor defines in
.bazelrc.absl:These defines are applied for all platforms (Linux, macOS, Windows) alongside the existing
DD_USE_ABSEIL_FOR_ENVOYmacro.