Skip to content

version-checking release script #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgoffredo merged 2 commits into from
Mar 31, 2023
Merged

version-checking release script #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cded8f9
bin/check-version
dgoffredo Mar 31, 2023
67f4155
add release script
dgoffredo Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions bin/check-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
#!/bin/sh

set -e

desired="$1"
pattern='^v[0-9]\+\.[0-9]\.[0-9]\+$'
if echo "$desired" | grep -v "$pattern" >/dev/null 2>&1; then
>&2 echo "Specified version \"$desired\" does not match the grep pattern $pattern"
exit 1
fi

scratch=$(mktemp -d)
version_cpp="$(dirname "$0")/../src/datadog/version.cpp"
cp "$version_cpp" "$scratch"
cp "${version_cpp%.cpp}.h" "$scratch"
>"$scratch/print_version.cpp" cat <<'END_CPP'

#include "version.h"
#include <iostream>

int main() {
std::cout << datadog::tracing::tracer_version;
}
END_CPP

/usr/bin/c++ -o "$scratch/print_version" "$scratch"/*.cpp
actual=$("$scratch/print_version")
rm -r "$scratch"

if [ "$actual" != "$desired" ]; then
version_cpp="$(realpath --relative-to="$(pwd)" "$version_cpp")"
>&2 echo "Desired release version \"$desired\" is different from that in $version_cpp: \"$actual\""
exit 1
fi
8 changes: 8 additions & 0 deletions bin/release
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/sh

set -e

version="$1"
bin="$(dirname "$0")"
"$bin"/check-version "$version" || exit
gh release create "$version" --prerelease --draft
6 changes: 4 additions & 2 deletions src/datadog/version.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
namespace datadog {
namespace tracing {

const char* const tracer_version = "v0.1.5";
const char* const tracer_version_string = "[dd-trace-cpp version v0.1.5]";
#define VERSION "v0.1.8"

const char* const tracer_version = VERSION;
const char* const tracer_version_string = "[dd-trace-cpp version " VERSION "]";

} // namespace tracing
} // namespace datadog
4 changes: 2 additions & 2 deletions src/datadog/version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

// This component provides the release version of this library.

#include "string_view.h"

namespace datadog {
namespace tracing {

// The release version at or before this code revision, e.g. "v0.1.1".
// That is, this code is at least as recent as `tracer_version`, but may be
// more recent.
extern const char *const tracer_version;

// A string literal that contains `tracer_version` but also is easier to `grep`
Expand Down