Skip to content

chore(ci): use dd-sts for system-tests test optimization#306

Draft
nccatoni wants to merge 1 commit intomainfrom
nccatoni/system-tests-dd-sts
Draft

chore(ci): use dd-sts for system-tests test optimization#306
nccatoni wants to merge 1 commit intomainfrom
nccatoni/system-tests-dd-sts

Conversation

@nccatoni
Copy link
Copy Markdown
Contributor

@nccatoni nccatoni commented Apr 9, 2026

Use OIDC-based dd-sts authentication to push test results to Test Optimization from within the system-tests reusable workflow, removing the need for a hardcoded secret.

Policy: https://github.com/DataDog/dd-source/tree/main/domains/seceng/sit/apps/apis/dd-sts/config/policies/us1.ddbuild.io/dd-trace-cpp-system-tests.yaml

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 9, 2026 •
edited
Loading

Benchmarks

Benchmark execution time: 2026-04-09 14:48:53

Comparing candidate commit 3e7d454 in PR branch nccatoni/system-tests-dd-sts with baseline commit 967246f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@nccatoni nccatoni force-pushed the nccatoni/system-tests-dd-sts branch from eb311bf to 3e7d454 Compare April 9, 2026 14:44
@datadog-prod-us1-4
Copy link
Copy Markdown

datadog-prod-us1-4 bot commented Apr 9, 2026

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 90.89% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3e7d454 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nccatoni