Skip to content

ci: disable legacy Gitlab exec in order to fix jobs failing with green status#6097

Merged
BridgeAR merged 1 commit intomasterfrom
ddyurchenko/disable-legacy-gitlab-exec
Jul 15, 2025
Merged

ci: disable legacy Gitlab exec in order to fix jobs failing with green status#6097
BridgeAR merged 1 commit intomasterfrom
ddyurchenko/disable-legacy-gitlab-exec

Conversation

@ddyurchenko
Copy link
Copy Markdown
Contributor

What does this PR do?

Disables FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY that we used before to ensure build containers have QoS guaranteed. As of now, it doesn't seem to be necessary anymore, but leads to problems like https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4119.

Motivation

Fix issue with GItlab CI jobs silently randomly failing with a green status.

@ddyurchenko ddyurchenko requested a review from a team as a code owner July 15, 2025 09:53
@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.67 MB
Deduped: 109.25 MB
No deduping: 109.64 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.0.0 | 20.3 MB | 20.31 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.02%. Comparing base (195f0ce) to head (2fb7ae5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6097      +/-   ##
==========================================
+ Coverage   81.94%   82.02%   +0.07%     
==========================================
  Files         473      468       -5     
  Lines       19560    19467      -93     
==========================================
- Hits        16029    15968      -61     
+ Misses       3531     3499      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jul 15, 2025

Benchmarks

Benchmark execution time: 2025-07-15 10:01:01

Comparing candidate commit 2fb7ae5 in PR branch ddyurchenko/disable-legacy-gitlab-exec with baseline commit 195f0ce in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1271 metrics, 52 unstable metrics.

@BridgeAR BridgeAR merged commit 765635b into master Jul 15, 2025
678 of 680 checks passed
@BridgeAR BridgeAR deleted the ddyurchenko/disable-legacy-gitlab-exec branch July 15, 2025 11:59
andrewlock added a commit to DataDog/dd-trace-dotnet that referenced this pull request Jul 15, 2025
…atus (#7223)

## Summary of changes

Disables `FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY` that we used
before to ensure build containers have QoS guaranteed. As of now, it
doesn't seem to be necessary anymore, but leads to problems like
https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4119.

## Reason for change

Apparently it there were issues with Gitlab CI jobs silently randomly
failing with a green status.

## Implementation details

Delete usages of `FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY` and
`KUBERNETES_SERVICE_ACCOUNT_OVERWRITE`

## Test coverage

This is the test

## Other details

I based this email on similar PRs raised by @ddyurchenko e.g.
- DataDog/dd-trace-cpp#225
- DataDog/dd-trace-js#6097
@ghost ghost mentioned this pull request Jul 17, 2025
ghost pushed a commit that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants