Skip to content

Remote config support for the WAF#71

Merged
cataphract merged 3 commits intomasterfrom
glopes/waf-rem-cfg
Sep 5, 2024
Merged

Remote config support for the WAF#71
cataphract merged 3 commits intomasterfrom
glopes/waf-rem-cfg

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

@cataphract cataphract commented Apr 23, 2024 •
edited
Loading

Updates dd-trace-cpp to the version in this PR this PR and registers listeners for the WAF products.

@cataphract cataphract requested review from a team as code owners April 23, 2024 14:41
@Anilm3 Anilm3 requested a review from estringana April 23, 2024 14:50
@cataphract cataphract force-pushed the glopes/waf-rem-cfg branch 4 times, most recently from 2e5f3ef to e1e7ac9 Compare May 1, 2024 09:07
Base automatically changed from glopes/waf to master May 14, 2024 10:43
@cataphract cataphract force-pushed the glopes/waf-rem-cfg branch from e1e7ac9 to e69d10d Compare June 4, 2024 13:40
@cataphract cataphract requested a review from a team as a code owner August 6, 2024 17:44
@cataphract cataphract requested review from zacharycmontoya and removed request for a team August 6, 2024 17:44
@cataphract cataphract mentioned this pull request Aug 6, 2024
Merged
dmehala
dmehala reviewed Aug 7, 2024
View reviewed changes
Comment thread src/request_tracing.cpp Outdated
Comment thread src/tracing_library.cpp Outdated
Comment thread src/tracing_library.cpp Outdated
Comment thread src/tracing_library.cpp Outdated
Comment thread src/security/waf_remote_cfg.cpp
Comment thread src/tracing_library.cpp
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.27063% with 108 lines in your changes missing coverage. Please review.

Project coverage is 69.27%. Comparing base (2146517) to head (a626e89).
Report is 99 commits behind head on master.

Files with missing lines Patch % Lines
src/security/waf_remote_cfg.cpp 80.04% 71 Missing and 26 partials ⚠️
src/security/library.cpp 37.50% 7 Missing and 3 partials ⚠️
src/ngx_logger.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   67.08%   69.27%   +2.18%     
==========================================
  Files          35       36       +1     
  Lines        3476     4000     +524     
  Branches      606      671      +65     
==========================================
+ Hits         2332     2771     +439     
- Misses        826      880      +54     
- Partials      318      349      +31
Files with missing lines Coverage Δ
src/ngx_http_datadog_module.cpp 61.22% <100.00%> (+0.64%) ⬆️
src/security/library.h 100.00% <ø> (+66.66%) ⬆️
src/tracing_library.cpp 84.90% <100.00%> (+1.74%) ⬆️
src/ngx_logger.cpp 95.65% <50.00%> (-4.35%) ⬇️
src/security/library.cpp 60.05% <37.50%> (+1.03%) ⬆️
src/security/waf_remote_cfg.cpp 80.04% <80.04%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cataphract cataphract force-pushed the glopes/waf-rem-cfg branch 4 times, most recently from be24d0a to 27d2adb Compare August 22, 2024 07:54
@cataphract cataphract force-pushed the glopes/waf-rem-cfg branch 2 times, most recently from e7cdfb0 to 38e07b6 Compare August 22, 2024 08:00
@cataphract cataphract requested a review from dmehala August 23, 2024 13:08
@dmehala dmehala force-pushed the glopes/waf-rem-cfg branch from ca2b4ff to 1f5d274 Compare August 27, 2024 13:57
@dmehala
Copy link
Copy Markdown
Contributor

dmehala commented Aug 27, 2024

Hey @cataphract,
I rebased your branch on top of master.

dmehala
dmehala approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmehala dmehala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit: Thanks for your contribution!
For my own curiosity, do you plan to demo this feature? If yes, can I be invited?

@cataphract cataphract merged commit 07ae9ee into master Sep 5, 2024
@cataphract cataphract deleted the glopes/waf-rem-cfg branch September 5, 2024 16:28
dmehala added a commit that referenced this pull request Sep 19, 2024
@dmehala
build(test): restrict gdb-15 install to amd64 architecture
bb2ae08 
PR #71 updates gdb to a newer version that supports reading DWARF debugging
format. However, it incorrectly attempts to install the x86_64 version
regardless of the system's architecture, causing errors on non-x86_64 platforms.

This fix temporarily ensures that the updated gdb is only installed on x86_64
(amd64) systems.
@dmehala dmehala mentioned this pull request Sep 19, 2024
Merged
dmehala added a commit that referenced this pull request Sep 19, 2024
@dmehala
build(test): restrict gdb-15 install to amd64 architecture
2b2bf27 
PR #71 updates gdb to a newer version that supports reading DWARF debugging
format. However, it incorrectly attempts to install the x86_64 version
regardless of the system's architecture, causing errors on non-x86_64 platforms.

This fix temporarily ensures that the updated gdb is only installed on x86_64
(amd64) systems.
dmehala added a commit that referenced this pull request Sep 19, 2024
@dmehala
build(test): restrict gdb-15 install to amd64 architecture
8fa19d4 
PR #71 updates gdb to a newer version that supports reading DWARF debugging
format. However, it incorrectly attempts to install the x86_64 version
regardless of the system's architecture, causing errors on non-x86_64 platforms.

This fix temporarily ensures that the updated gdb is only installed on x86_64
(amd64) systems.
dmehala added a commit that referenced this pull request Sep 19, 2024
@dmehala
build(test): restrict gdb-15 install to amd64 architecture (#114)
630a7fe 
PR #71 updates gdb to a newer version that supports reading DWARF debugging
format. However, it incorrectly attempts to install the x86_64 version
regardless of the system's architecture, causing errors on non-x86_64 platforms.

This fix temporarily ensures that the updated gdb is only installed on x86_64
(amd64) systems.
cataphract pushed a commit that referenced this pull request Oct 30, 2024
@dmehala @cataphract
build(test): restrict gdb-15 install to amd64 architecture (#114)
95c283b 
PR #71 updates gdb to a newer version that supports reading DWARF debugging
format. However, it incorrectly attempts to install the x86_64 version
regardless of the system's architecture, causing errors on non-x86_64 platforms.

This fix temporarily ensures that the updated gdb is only installed on x86_64
(amd64) systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anilm3 Anilm3 Anilm3 left review comments

@estringana estringana Awaiting requested review from estringana

@zacharycmontoya zacharycmontoya Awaiting requested review from zacharycmontoya zacharycmontoya was automatically assigned from DataDog/dd-trace-cpp

+1 more reviewer

@dmehala dmehala dmehala approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cataphract @codecov-commenter @dmehala @Anilm3