Skip to content

build(cpp): Update build args for dd-trace-cpp#2468

Merged
cbeauchesne merged 3 commits intomainfrom
dmehala/update-cpp-build
May 24, 2024
Merged

build(cpp): Update build args for dd-trace-cpp#2468
cbeauchesne merged 3 commits intomainfrom
dmehala/update-cpp-build

Conversation

@dmehala
Copy link
Copy Markdown
Contributor

@dmehala dmehala commented May 21, 2024

Motivation

DataDog/dd-trace-cpp#119 changes build argument.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Note to reviewers

Prod is failing for this exact reason. Since, dd-trace-cpp@HEAD is not as I considered prod. Could you change the system-test to only consider the latest release as of prod?

@dmehala dmehala marked this pull request as ready for review May 21, 2024 09:01
@dmehala dmehala requested review from a team and Kyle-Verhoog as code owners May 21, 2024 09:01
@robertomonteromiguel
Copy link
Copy Markdown
Collaborator

There are test failures related with this PR. I move it to "draft"

@robertomonteromiguel robertomonteromiguel marked this pull request as draft May 21, 2024 12:28
@dmehala dmehala marked this pull request as ready for review May 22, 2024 18:49
@dmehala
Copy link
Copy Markdown
Contributor Author

dmehala commented May 23, 2024

The PR is ready for review @robertomonteromiguel

Copy link
Copy Markdown
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are test failures related with this PR? Parametric Prod
There is another PR trying to solve the same, but this PR fails for Parametric Dev
https://github.com/DataDog/system-tests/pull/2468/files

@cbeauchesne cbeauchesne force-pushed the dmehala/update-cpp-build branch from 3ead51f to 50624fb Compare May 24, 2024 08:58
@cbeauchesne cbeauchesne merged commit a71e5d9 into main May 24, 2024
@cbeauchesne cbeauchesne deleted the dmehala/update-cpp-build branch May 24, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants