build(cpp): Update build args for dd-trace-cpp#2468
Merged
cbeauchesne merged 3 commits intomainfrom May 24, 2024
Merged
Conversation
Collaborator
|
There are test failures related with this PR. I move it to "draft" |
Contributor
Author
|
The PR is ready for review @robertomonteromiguel |
robertomonteromiguel
requested changes
May 24, 2024
Collaborator
robertomonteromiguel
left a comment
There was a problem hiding this comment.
There are test failures related with this PR? Parametric Prod
There is another PR trying to solve the same, but this PR fails for Parametric Dev
https://github.com/DataDog/system-tests/pull/2468/files
8 tasks
3ead51f to
50624fb
Compare
cbeauchesne
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DataDog/dd-trace-cpp#119 changes build argument.
Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presents[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is presentNote to reviewers
Prod is failing for this exact reason. Since,
dd-trace-cpp@HEADis not as I considered prod. Could you change the system-test to only consider the latest release as of prod?