[parametric] add remote config tests with empty DD_SERVICE or DD_ENV#3778
Merged
lucaspimentel merged 3 commits intomainfrom Jan 9, 2025
Merged
Conversation
a1df6cb to
890f990
Compare
DD_ENVDD_SERVICE or DD_ENV
a86262e to
3a7ada6
Compare
DD_SERVICE or DD_ENVDD_SERVICE or DD_ENV
4184f69 to
5bf407e
Compare
cbeauchesne
approved these changes
Jan 9, 2025
bwoebi
reviewed
Jan 9, 2025
fbddfa1 to
b55074f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some tracing libraries added checks for matching
serviceandenvin remote config payloads. For example, DataDog/dd-trace-java#6636. This causes issues in scenarios like SSI where theenv(akaDD_ENV) is configured in the agent, but not on the tracer. The Java tracer is rejecting remote sampling rules in SSI, which prevents Adaptive Sampling from working correctly.See also APM_TRACING matching & SSI 🔒
Changes
Add a new test that asserts that the tracing library accepts a remote config payload without checking for matching
serviceorenv, since that is already handled by the agent.Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present