Merged
Conversation
Member
Author
|
This PR also contains the |
Contributor
|
No, at least I include them usually for my projects |
majuwa
reviewed
Jul 6, 2022
Contributor
majuwa
left a comment
There was a problem hiding this comment.
It mostly looks fine to me. I have only some minor comments regarding some minor details
bundles/org.palladiosimulator.dataflow.confidentiality.analysis/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
...imulator.dataflow.confidentiality.analysis/models/BranchingOnlineShop/My.resourceenvironment
Show resolved
Hide resolved
.../dataflow/confidentiality/analysis/sequence/entity/pcm/AbstractPCMActionSequenceElement.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the initial class structure of the analysis. Currently, it lacks of the implementation of sequence finder and label propagation but should already be runnable as standalone analysis that loads the required models. This is enough functionality to early test the modeling repository (and maybe even fix the build? 😢)