Updated vignettes and library table#212
Merged
graemeblair merged 3 commits intoDeclareDesign:masterfrom Nov 16, 2018
Nick-Rivera:master
Merged
Updated vignettes and library table#212graemeblair merged 3 commits intoDeclareDesign:masterfrom Nick-Rivera:master
graemeblair merged 3 commits intoDeclareDesign:masterfrom
Nick-Rivera:master
Conversation
Pull Request Test Coverage Report for Build 1089
💛 - Coveralls |
graemeblair
reviewed
Nov 16, 2018
Member
graemeblair
left a comment
There was a problem hiding this comment.
why is it renaming back to simple_ here in the table?
Contributor
Author
|
There were no vignettes named spillover and two_arm, but there are simple_two_arm and simple_spillover. If that row isn't supposed to have those vignettes, I can delete those entries. |
Member
|
sounds like we need to rename the vignettes in line with the designers @jaspercooper |
Member
|
@jaspercooper can this be merged in? |
Contributor
|
Please go ahead if you don’t mind. Thanks both!
…On Fri, Nov 16, 2018 at 17:27 Graeme Blair ***@***.***> wrote:
@jaspercooper <https://github.com/jaspercooper> can this be merged in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#212 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGeRUS3sCuGcIbtVEeQNdXZyaNjuGyiZks5uvzvYgaJpZM4Yk7ct>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
{{{wouldn’t be interpreted as special characters by the site generator.