Closed
Conversation
jeylau
reviewed
Aug 16, 2023
Contributor
jeylau
left a comment
There was a problem hiding this comment.
Looks fine to me! I guess we'll get rid of the extra data in examples/
| net_type=None, | ||
| augmenter_type=None, | ||
| posecfg_template=None, | ||
| superanimal_name = "" |
Contributor
There was a problem hiding this comment.
Is this argument meant to be user-facing? Or only for internal purposes? It is very redundant with posecfg_template.
Collaborator
Author
There was a problem hiding this comment.
I am not sure it was me who put it there. Is it used anywhere in the source code?
Contributor
There was a problem hiding this comment.
It's not; I'll get rid of it.
Comment on lines
+200
to
+222
| from deeplabcut.modelzoo.utils import parse_available_supermodels | ||
| from dlclibrary.dlcmodelzoo.modelzoo_download import ( | ||
| download_huggingface_model, | ||
| MODELOPTIONS, | ||
| ) | ||
| import glob | ||
| dlc_root_path = auxiliaryfunctions.get_deeplabcut_path() | ||
| supermodels = parse_available_supermodels() | ||
| weight_folder = str( | ||
| Path(dlc_root_path) | ||
| / "pose_estimation_tensorflow" | ||
| / "models" | ||
| / "pretrained" | ||
| / (superanimal_name + "_weights") | ||
| ) | ||
|
|
||
| if superanimal_name in MODELOPTIONS: | ||
| if not os.path.exists(weight_folder): | ||
| download_huggingface_model(superanimal_name, weight_folder) | ||
| else: | ||
| print(f"{weight_folder} exists, using the downloaded weights") | ||
| else: | ||
| print(f"{superanimal_name} not available. Available ones are: ", MODELOPTIONS) |
Contributor
There was a problem hiding this comment.
We could move the imports higher up, and test early whether superanimal_name is in MODELOPTIONS.
Member
|
We need the superanimal name... it was discussed and reviewed and in other code with @n-poulsen |
Member
|
closing as redundant with #2389 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SA fine-tuning code
Added a new example project for testing fine-tuning
Added a testscript