Conversation
snapshot_index and detector_snapshot_index parameters to API methodsanalyze_videos() and extend overrides to other methods
analyze_videos() and extend overrides to other methodsanalyze_videos and extend overrides to other methods
analyze_videos and extend overrides to other methodsanalyze_videos and extend overrides to other methods
9409664 to
2ce7d29
Compare
analyze_videos and extend overrides to other methodsanalyze_videos and extend overrides to other methods
Contributor
|
Tested the different methods with some videos with this PR across a bunch of projects and different snapshots for both the pose and detector models. |
AlexEMG
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in the PyTorch
analyze_videospipeline and extends the API for consistency across high-level methods.Bug Fix
Issue: When calling
analyze_videos()with non-defaultsnapshot_indexordetector_snapshot_indexarguments, predictions used the correct indexes, but the tracking stages (convert_detections2tracklets()andstitch_tracklets()) always defaulted to the values fromconfig.yaml. This caused crashes.Fix: Routed the argument-specified indexes through to the tracking methods, ensuring consistent behavior.
API Extension
Added
**torch_kwargsto the following methods:Similarly to
analyze_videos, these methods now support overridingsnapshot_indexanddetector_snapshot_indexvia arguments, in addition to the existingconfig.yamloptions.This keeps the PyTorch backend consistent with TensorFlow while providing more flexibility to users.