Move conditions: to inference: block and document inference-related configs#3106
Merged
Move conditions: to inference: block and document inference-related configs#3106
conditions: to inference: block and document inference-related configs#3106Conversation
361c407 to
094c808
Compare
conditions: to inference: block and document inference-related configs
Contributor
|
Thanks for documenting these changes and fixing the notebook. |
Contributor
Author
|
Thanks @arashsm79 ! I also addressed your previous review in this Pull Request, by:
|
Check for non-existing keys, add note to docs
1427334 to
c1f73ff
Compare
AlexEMG
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Moved the
conditions:block from thedata:section into the newinference:block inpytorch_config.yaml. This is more logical because thedata:block should only configure data augmentation.Updated the
net_typeused in the CTD/BUCTD Colab notebook fromctd_prenet_rtmpose_mtoctd_coam_w32, as thectd_prenet_rtmpose_mvariant has shown issues during training. The fix for allctd_prenet_rtmposevariants will be implemented in a future PR.Added documentation for the
inference:block in the PyTorch configuration docs, covering all sub-configs:torch.compilesettings.Notes:
These changes improve the clarity and maintainability of the configuration file by separating data augmentation from inference-specific settings.
Default behaviors remain unchanged for all users.