Skip to content

Move conditions: to inference: block and document inference-related configs#3106

Merged
AlexEMG merged 13 commits intomainfrom
maxim/move_ctd_conds
Oct 1, 2025
Merged

Move conditions: to inference: block and document inference-related configs#3106
AlexEMG merged 13 commits intomainfrom
maxim/move_ctd_conds

Conversation

@maximpavliv
Copy link
Copy Markdown
Contributor

@maximpavliv maximpavliv commented Sep 24, 2025

Summary of changes:

  • Moved the conditions: block from the data: section into the new inference: block in pytorch_config.yaml. This is more logical because the data: block should only configure data augmentation.

  • Updated the net_type used in the CTD/BUCTD Colab notebook from ctd_prenet_rtmpose_m to ctd_coam_w32, as the ctd_prenet_rtmpose_m variant has shown issues during training. The fix for all ctd_prenet_rtmpose variants will be implemented in a future PR.

  • Added documentation for the inference: block in the PyTorch configuration docs, covering all sub-configs:

    • multithreading – controls preprocessing/prediction threading during inference.
    • compile – optional torch.compile settings.
    • autocast – optional mixed-precision settings.
    • conditions – specifies conditions to use for Conditional Top-Down models.

Notes:

  • These changes improve the clarity and maintainability of the configuration file by separating data augmentation from inference-specific settings.

  • Default behaviors remain unchanged for all users.

@maximpavliv maximpavliv marked this pull request as ready for review September 24, 2025 11:38
@maximpavliv maximpavliv changed the title Maxim/move ctd conds Move conditions: to inference: block and document inference-related configs Sep 24, 2025
@maximpavliv maximpavliv added COLAB CTD Contidional Top-Down labels Sep 24, 2025
@arashsm79
Copy link
Copy Markdown
Contributor

Thanks for documenting these changes and fixing the notebook.
LGTM.

@maximpavliv
Copy link
Copy Markdown
Contributor Author

Thanks @arashsm79 !

I also addressed your previous review in this Pull Request, by:

  • Introducing dot-notation update support for inference_cfg, while keeping the existing nested dict construction/update mechanism
  • Making sure an Exception is raised if a non-existing key is passed (in both dot-notation and nested dict notation updates)
  • Adding a note about torch.compile and ctd_coam_* issues to the docs

@maximpavliv maximpavliv marked this pull request as draft October 1, 2025 13:09
Check for non-existing keys, add note to docs
@maximpavliv maximpavliv force-pushed the maxim/move_ctd_conds branch from 1427334 to c1f73ff Compare October 1, 2025 14:14
@maximpavliv maximpavliv marked this pull request as ready for review October 1, 2025 15:04
@AlexEMG AlexEMG merged commit bb9cc68 into main Oct 1, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

COLAB CTD Contidional Top-Down DLC3.0🔥

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants