fix non-deterministic unintended failing of test_coarse_dropout#3182
Merged
deruyter92 merged 3 commits intoDeepLabCut:mainfrom Jan 23, 2026
Merged
fix non-deterministic unintended failing of test_coarse_dropout#3182deruyter92 merged 3 commits intoDeepLabCut:mainfrom
test_coarse_dropout#3182deruyter92 merged 3 commits intoDeepLabCut:mainfrom
Conversation
dropout is applied over nearly (!) the entire image (e,g. max_width=.9999), to test that randomly placed keypoints always become nan. However, the boundaries for the randomly generated keypoints exceeded the boundaries of the dropout. This is now fixed by generating keypoints maximally within 1 pixel distance of the image border.
MMathisLab
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue in one of the pytests testing the dropout transformation.
problem:
The test fails non-deterministically because of an issue in the test implementation unrelated to the codebase.
Dropout is applied over nearly (!) the entire image (e,g. max_width=.9999), to test that randomly placed keypoints always become nan. However, the boundaries for the randomly generated keypoints exceeded the boundaries of the dropout. In rare cases the test fails when the keypoints are placed at the border of the image.
changes:
Fixed test implementation: keypoints are randomly generated at maximally 1 pixel distance of the image border.