Return normal hash as bare txid for coinbase#73
Merged
galpHub merged 1 commit intoDiviProject:Developmentfrom Mar 15, 2021
Merged
Return normal hash as bare txid for coinbase#73galpHub merged 1 commit intoDiviProject:Developmentfrom
galpHub merged 1 commit intoDiviProject:Developmentfrom
Conversation
For coinbase transactions, we have to return the normal txid as the "bare" hash. For them, there is not a real signature that could be malleated anyway, but instead the scriptSig is needed to make sure each coinbase transaction has a different hash from any others. In practice, this has no relevance, since no new coinbase transactions from PoW are created anyway after the future mainnet fork activation of segwit light. But for regtests it is needed (and in general required to make sure all is correct).
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For coinbase transactions, we have to return the normal txid as the "bare" hash. For them, there is not a real signature that could be malleated anyway, but instead the scriptSig is needed to make sure each coinbase transaction has a different hash from any others.
In practice, this has no relevance, since no new coinbase transactions from PoW are created anyway after the future mainnet fork activation of segwit light. But for regtests it is needed (and in general required to make sure all is correct).