Fix delimited function. Added Unit Test.#48
Merged
underrun merged 2 commits intoDomainTools:masterfrom Mar 25, 2020
Merged
Conversation
Closed
tangobango5
approved these changes
Mar 23, 2020
underrun
suggested changes
Mar 24, 2020
Contributor
underrun
left a comment
There was a problem hiding this comment.
Looks like the parameter was added but never used - thanks for catching this!
One tweak, then we'll merge.
Co-Authored-By: Derek Wilson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
domain_searchAPI expects space-separatedexclude_queryterms and not|separated. This diff aims to fix the fundamental issue indelimitedfunction.https://www.domaintools.com/resources/api-documentation/domain-search/