Add code to make definition lookup work with latest version of Jedi#1085
Merged
DonJayamanne merged 2 commits intoDonJayamanne:masterfrom Jul 20, 2017
Merged
Add code to make definition lookup work with latest version of Jedi#1085DonJayamanne merged 2 commits intoDonJayamanne:masterfrom
DonJayamanne merged 2 commits intoDonJayamanne:masterfrom
Conversation
Contributor
|
Great work! |
Owner
DonJayamanne
left a comment
There was a problem hiding this comment.
Please could you change the names from extract range 1 and 2 to something more meaningful
Contributor
Author
|
Happy to. Any suggestions? I started off calling them _old and _new, but a new version of Jedi might lead to the _newnew case in the future so that seemed less than great. |
Contributor
Author
|
I changed the names to match the Jedi versions they are associated with, let me know if you have another preference/suggestion, happy to tweak it. |
DonJayamanne
added a commit
that referenced
this pull request
Jul 20, 2017
* 'master' of https://github.com/DonJayamanne/pythonVSCode: Add code to make definition lookup work with latest version of Jedi (#1085) Add PEP 526 AutoCompletion (#1102)
vwxyzjn
pushed a commit
to vwxyzjn/pythonVSCode
that referenced
this pull request
Jul 21, 2017
…onJayamanne#1085) * Add code to make definition lookup work with latest version of Jedi * Change function names to include Jedi version they are associated with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #870 and #961