Enable "System Default" Auto Night Mode for all Android versions#1928
Open
Ephemera42 wants to merge 1 commit intoDrKLO:masterfrom
Open
Enable "System Default" Auto Night Mode for all Android versions#1928Ephemera42 wants to merge 1 commit intoDrKLO:masterfrom
Ephemera42 wants to merge 1 commit intoDrKLO:masterfrom
Conversation
Previously, the "System Default" option for Auto Night Mode was restricted to Android 10 (SDK 29) and above. This commit removes the SDK version check in both the configuration logic and the UI. * In Theme.java: Sets the default `selectedAutoNightType` to `AUTO_NIGHT_TYPE_SYSTEM` regardless of the OS version. * In ThemeActivity.java: Unhides the "System Default" row for devices running Android 9 and older.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since night mode support was introduced as early as API 8, the "System Default" option can function correctly on older Android versions and should not be restricted to Android 10+ devices.
Preview.mp4