Skip to content

Added tensorboard#4

Merged
xuty-007 merged 1 commit intoDropEdge:masterfrom
mdsalnikov:master
Mar 4, 2020
Merged

Added tensorboard#4
xuty-007 merged 1 commit intoDropEdge:masterfrom
mdsalnikov:master

Conversation

@mdsalnikov
Copy link
Copy Markdown
Contributor

Hello,
I added tensorboard for visualization, if it's ok, please add it to project.

@DropEdge
Copy link
Copy Markdown
Owner

Hi MihailSalnikov,
Thanks a lot for your code of better visualization! We'll review the code and re-run all experiments to ensure reproducibility. If everything is OK, we'll merge it into master asap.

Copy link
Copy Markdown
Collaborator

@xuty-007 xuty-007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We re-run the code in virtualenv and find that torch 0.4.0 does not include tensorboard. Please use tensorboardX instead. After the changes mentioned in the comments. The code should pass and get the same results as before.

@mdsalnikov mdsalnikov requested a review from xuty-007 January 25, 2020 11:02
@xuty-007
Copy link
Copy Markdown
Collaborator

xuty-007 commented Mar 2, 2020

Thank you for your work. I've checked all the code and revisions. Everything is right. We'll merge it soon.

@xuty-007 xuty-007 merged commit 6267e93 into DropEdge:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants