Skip to content
This repository was archived by the owner on Jan 14, 2018. It is now read-only.

Release 1.3.2#206

Merged
enriquez merged 5 commits intomasterfrom
release/1.3.2
Nov 10, 2013
Merged

Release 1.3.2#206
enriquez merged 5 commits intomasterfrom
release/1.3.2

Conversation

@jeffarena
Copy link
Copy Markdown

Patch release fixing a number of bugs since the 1.3.1 release.

@enriquez
Copy link
Copy Markdown
Member

👍

I've been updating the README as well where it specifies how to install the CocoaPod with the specific version. I think it is safe to just say...

pod "ECSlidingViewController", :tag => "~> 1.3"

...without the patch number

@jeffarena
Copy link
Copy Markdown
Author

I believe you're correct. Updated.

enriquez added a commit that referenced this pull request Nov 10, 2013
@enriquez enriquez merged commit ed40854 into master Nov 10, 2013
@enriquez
Copy link
Copy Markdown
Member

Updated ECSlidingViewController CocoaPod to 1.3.2 CocoaPods/Specs@4932876. Thanks @jeffarena!

@jeffarena jeffarena deleted the release/1.3.2 branch November 10, 2013 22:54
@calimarkus
Copy link
Copy Markdown

Anyone else has the problem, that the view height is wrong on ios6 (built with ios7 SDK)?? It's 20pt too high.

I fixed it in my subclass like this:

- (CGRect)fullViewBounds
{
  if ([[[UIDevice currentDevice] systemVersion] floatValue] >= 7.0) {
       return [super fullViewBounds];
  }

  return (CGRect){CGPointZero, [[UIScreen mainScreen] applicationFrame].size};
}

@jeffarena
Copy link
Copy Markdown
Author

@jaydee3 are you able to demonstrate the problem with the sample app? i checked things out yesterday before cutting the release branch and everything looked happy on iOS 6.

@elektrojunge
Copy link
Copy Markdown

@jeffarena I just ran into this when I updated to 1.3.2. It happens when you run the sample app on iOS 6.1. Just add a couple of more items to SampleTableViewController and you can see for yourself. I just played around a bit and it works correctly in 1.3.0, seems like the bug was introduced in 1.3.1

@calimarkus
Copy link
Copy Markdown

jep perfectly visible in the example app, just add more rows to the tableview example. @jeffarena

@jeffarena
Copy link
Copy Markdown
Author

I'll take a look and get a fix pushed later today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants