This repository was archived by the owner on Jan 14, 2018. It is now read-only.
Allow default transition duration to be set#305
Closed
iwasrobbed wants to merge 2 commits intomasterfrom
unknown repository
Closed
Allow default transition duration to be set#305iwasrobbed wants to merge 2 commits intomasterfrom unknown repository
iwasrobbed wants to merge 2 commits intomasterfrom
unknown repository
Conversation
This allows a user to not rely on the delegate pattern
Member
|
I manually merged the default transition duration commit here 4b8073b As for the notifications, I think they duplicate the same behavior as the view appearance callbacks. |
Contributor
Author
|
Thanks Mike! We just needed the notifications since the delegation callbacks caused a lot of coupling. Since we're using this pod for a notifications panel, there were too many views that could be launched from the panel and it made knowing when the panel was closed very messy (duplicate / unnecessary code in unrelated VCs). If there is a better way to have optional notifications for open/close/reset events, please let me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.