Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[RedHat.com] Update and reactivate ruleset#10708

Merged
J0WI merged 5 commits intoEFForg:masterfrom
Bisaloo:patch-51
Jul 26, 2017
Merged

[RedHat.com] Update and reactivate ruleset#10708
J0WI merged 5 commits intoEFForg:masterfrom
Bisaloo:patch-51

Conversation

@Bisaloo
Copy link
Copy Markdown
Collaborator

@Bisaloo Bisaloo commented Jun 26, 2017

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Jun 26, 2017

partner.redhat.com returns 404 over HTTPS, please remove the target and add it to nonfunctional domains. I sent a pull request to your fork.

@J0WI
Copy link
Copy Markdown
Contributor

J0WI commented Jun 26, 2017

@koops76 I was not able to reproduce the 404 on partner.redhat.com. Do you have an example for this?

@Bisaloo
Copy link
Copy Markdown
Collaborator Author

Bisaloo commented Jun 26, 2017 •
edited
Loading

@J0WI, that's strange, I can reproduce by visiting http://partner.redhat.com/ with HTTPS-Everywhere enabled. I'm using FF 54.0.

EDIT: Wait, I can't now. But it was 404ing just minutes ago...

@Bisaloo
Copy link
Copy Markdown
Collaborator Author

Bisaloo commented Jun 26, 2017

Okay, I am not sure what is going on but:

@ghost
Copy link
Copy Markdown

ghost commented Jun 26, 2017

Maybe just add this redirect to the ruleset?

@Bisaloo
Copy link
Copy Markdown
Collaborator Author

Bisaloo commented Jun 26, 2017

I'd rather not. It's probably not the safest idea to blindly add a rewrite rule when we are not fully understanding what is going on.

For example, this could the sign that they are in the process of updating their website and a complicated rewrite rule could break the website in the next couple of days.

@ghost
Copy link
Copy Markdown

ghost commented Jun 26, 2017

@Bisaloo First it redirects to https://www.redhat.com/wapps/sfconnector/partner/login.html which 404s, but the next time it redirects to redhat.secure.force.com

@ghost ghost mentioned this pull request Jun 26, 2017
Closed
@J0WI
Copy link
Copy Markdown
Contributor

J0WI commented Jul 26, 2017

@Bisaloo is this now ready to merge?

@Bisaloo
Copy link
Copy Markdown
Collaborator Author

Bisaloo commented Jul 26, 2017

Yes, the issue I had got fixed server side.

@J0WI J0WI merged commit f11c19d into EFForg:master Jul 26, 2017
@Bisaloo Bisaloo deleted the patch-51 branch July 27, 2017 05:27
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
@Bisaloo @luciancor
[RedHat.com] Update and reactivate ruleset (EFForg#10708)
d72b1cf 
* [RedHat.com] Update and reactivate ruleset

* [WordPress-blogs] Remove redhat.com

* Update Red_Hat.xml (cliqz-oss#5)

* [RedHat.com] Update top comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

top-10k

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bisaloo @J0WI @Hainish