Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create Steamrep.com.xml#1222

Closed
john-kk wants to merge 1 commit intoEFForg:masterfrom
john-kk:patch-1
Closed

Create Steamrep.com.xml#1222
john-kk wants to merge 1 commit intoEFForg:masterfrom
john-kk:patch-1

Conversation

@john-kk
Copy link
Copy Markdown
Contributor

@john-kk john-kk commented Mar 22, 2015

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this actually doesn't work with the full www.steamrep.com -- maybe remove the www prefix?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just simplify to

<rule from="^http:"
    to="https:" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @semenko's suggestion is better: Since only steamrep.com works over HTTPS, both steamrep.com and www.steamrep.com should redirect to the HTTPS version of steamrep.com.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @semenko's suggestion is better: Since only steamrep.com works over HTTPS, both steamrep.com and www.steamrep.com should redirect to the HTTPS version of steamrep.com.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.steamrep.com works fine (i.e. no SSL error). 2d1 prefers not to preempting server's redirect.

Copy link
Copy Markdown
Member

@jsha jsha Jul 15, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost
Copy link
Copy Markdown

ghost commented Nov 9, 2015

Hi, I'm the author of this pull, I created a new account and I don't use the old one anymore, do I need to create new pull requests for this and the others pulls? Or if not how can I edit this pull with my new account?

@ghost
Copy link
Copy Markdown

ghost commented Nov 14, 2015

@Ekaris if you still can access your old account, I suggest closing this pull and create a new pull under your current account. or else, just create a new pull and reference this pull.

@ghost ghost mentioned this pull request Nov 16, 2015
@semenko
Copy link
Copy Markdown
Contributor

semenko commented Dec 17, 2015

Closed in favor of #3211

@semenko semenko closed this Dec 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants