Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

lrr.in.tum.de rule#5084

Closed
jbreitbart wants to merge 13 commits intoEFForg:masterfrom
jbreitbart:master
Closed

lrr.in.tum.de rule#5084
jbreitbart wants to merge 13 commits intoEFForg:masterfrom
jbreitbart:master

Conversation

@jbreitbart
Copy link
Copy Markdown
Contributor

No description provided.

@jbreitbart
Copy link
Copy Markdown
Contributor Author

Can someone explain to me why one of the travis tests fails? I don't see anything useful in the error log at https://travis-ci.org/EFForg/https-everywhere/jobs/136743355

@J0WI
Copy link
Copy Markdown
Contributor

J0WI commented Aug 23, 2016

We tend to always cover the whole *.tum.de host, not just a single subdomain.
Would you like to add others too? You can find a guide here:
https://github.com/EFForg/https-everywhere/blob/master/ruleset-style.md

@jbreitbart
Copy link
Copy Markdown
Contributor Author

I'm afraid, I cannot make any rule for the whole domain, there are too many subdomains that are not handled in a uniform way.

Please close the issue if you prefer not to have single subdomain rules.

@J0WI
Copy link
Copy Markdown
Contributor

J0WI commented Aug 25, 2016

We already have Technical_University_Munich.xml and Tum.de.xml (which seems obsolete anyway). You can add this host there.

@jbreitbart
Copy link
Copy Markdown
Contributor Author

@J0WI fixed + added some tests. Some of the certificates for TUM have expired and the tests fail. What is the best solution for this?

@J0WI
Copy link
Copy Markdown
Contributor

J0WI commented Sep 1, 2016

The best is to remove the targets/redirect rules for them and add comments on the top about their issue.

It would also be nice if you could remove the wildcard targets and replace them with the hosts that are supporting https. This would also avoid test urls and non-capturing groups.

@jbreitbart
Copy link
Copy Markdown
Contributor Author

@J0WI Fixed. Let me know if there are any more issues. Also feel-free to squash-merge.

<securecookie host="^(?:in|(?:adm9|ias|sec|www)\.in|mediatum\.ub|www(?:\.lehren?)?)?\.tum\.de$" name=".+" />
<securecookie host="^ias\.cs\.tum\.edu$" name=".+" />
<securecookie host="^(?:www|ias\.informatik)\.tu-muenchen\.de$" name=".+" />
<securecookie host="^(?:www\.informatik)\.tu-muenchen\.de$" name=".+" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add www.informatik.tu-muenchen.de as target host and replace all non-capturing groups in this ruleset ((?:www\.informatik)) with normal ones ((www\.informatik)?).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the target host, but I don't know how to remove the non-capturing groups. Sorry.

@J0WI
Copy link
Copy Markdown
Contributor

J0WI commented Sep 4, 2016

Please use a generic <rule from="^http:" to="https:" /> to just redirecting all listed targets to https.

@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Dec 3, 2016

@jbreitbart Are you still interested in working on this?

@jbreitbart
Copy link
Copy Markdown
Contributor Author

@jeremyn Thanks for the reminder.

I rebased my fork on the current master and updated it. See comments above.

@jeremyn jeremyn self-assigned this Dec 3, 2016
@jeremyn jeremyn closed this Dec 5, 2016
@jeremyn jeremyn reopened this Dec 5, 2016
@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Dec 20, 2016

Using Sublist3r (see the style guide) I see there are many, many more tum.de domains than what you've listed here. Do you mean in #5084 (comment) that you're not interested in adding any more domains than what are already included?

@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Jan 25, 2017

@jbreitbart I'm trying to figure out what to do with this pull request. Are you interested in adding the missing tum.de subdomains?

@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Mar 9, 2017

Hi @jbreitbart, are you still interested in working on this pull request? If not, I'm going to close it.

@jeremyn
Copy link
Copy Markdown
Contributor

jeremyn commented Mar 18, 2017

No response, closing.

@jeremyn jeremyn closed this Mar 18, 2017
@jeremyn jeremyn removed their assignment Mar 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants