Conversation
|
Can someone explain to me why one of the travis tests fails? I don't see anything useful in the error log at https://travis-ci.org/EFForg/https-everywhere/jobs/136743355 |
|
We tend to always cover the whole *.tum.de host, not just a single subdomain. |
|
I'm afraid, I cannot make any rule for the whole domain, there are too many subdomains that are not handled in a uniform way. Please close the issue if you prefer not to have single subdomain rules. |
|
We already have |
|
@J0WI fixed + added some tests. Some of the certificates for TUM have expired and the tests fail. What is the best solution for this? |
|
The best is to remove the targets/redirect rules for them and add comments on the top about their issue. It would also be nice if you could remove the wildcard targets and replace them with the hosts that are supporting https. This would also avoid test urls and non-capturing groups. |
|
@J0WI Fixed. Let me know if there are any more issues. Also feel-free to squash-merge. |
| <securecookie host="^(?:in|(?:adm9|ias|sec|www)\.in|mediatum\.ub|www(?:\.lehren?)?)?\.tum\.de$" name=".+" /> | ||
| <securecookie host="^ias\.cs\.tum\.edu$" name=".+" /> | ||
| <securecookie host="^(?:www|ias\.informatik)\.tu-muenchen\.de$" name=".+" /> | ||
| <securecookie host="^(?:www\.informatik)\.tu-muenchen\.de$" name=".+" /> |
There was a problem hiding this comment.
Please also add www.informatik.tu-muenchen.de as target host and replace all non-capturing groups in this ruleset ((?:www\.informatik)) with normal ones ((www\.informatik)?).
There was a problem hiding this comment.
I added the target host, but I don't know how to remove the non-capturing groups. Sorry.
|
Please use a generic |
|
@jbreitbart Are you still interested in working on this? |
|
@jeremyn Thanks for the reminder. I rebased my fork on the current master and updated it. See comments above. |
|
Using Sublist3r (see the style guide) I see there are many, many more |
|
@jbreitbart I'm trying to figure out what to do with this pull request. Are you interested in adding the missing |
|
Hi @jbreitbart, are you still interested in working on this pull request? If not, I'm going to close it. |
|
No response, closing. |
No description provided.