This repository was archived by the owner on Nov 6, 2023. It is now read-only.
partial rules for RWTH Aachen University#7525
Closed
herrriehm wants to merge 4 commits intoEFForg:masterfrom
Closed
partial rules for RWTH Aachen University#7525herrriehm wants to merge 4 commits intoEFForg:masterfrom
herrriehm wants to merge 4 commits intoEFForg:masterfrom
Conversation
J0WI
reviewed
Feb 21, 2017
| <target host="*.fsmpi.rwth-aachen.de" /> | ||
| <target host="*.itc.rwth-aachen.de" /> | ||
| <target host="*.physik.rwth-aachen.de" /> | ||
| <target host="*.rz.rwth-aachen.de" /> |
Contributor
There was a problem hiding this comment.
Our style guide recommends to avoid wildcards.
If they are really needed, please document why and add at least 3 test urls for each wildcard.
| <target host="www.iwe1.rwth-aachen.de" /> | ||
| <target host="www.iwomp2015.rwth-aachen.de" /> | ||
| <target host="www.kawo2.rwth-aachen.de" /> | ||
| <!-- <target host="www.kbsg.rwth-aachen.de" /> --> |
Contributor
There was a problem hiding this comment.
Please document the issue with the commented hosts.
You should list all of them in one single comment block on the top.
- removed commented targets - sorted according to styleguide - added some more targets
Author
|
I tried to solve problems which were shown from CI testing. But here are still some targets to which I can connect perfectly well: How should I handle them? |
Contributor
|
Please make a comment block on the top of the file and document them sorted by error type and host. |
Contributor
|
@herrriehm would be great if you could finish this |
Contributor
|
@herrriehm Are you still interested in working on this? |
Contributor
|
I'm closing this pull request due to lack of response from @herrriehm . I've noted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.