fixing interactions between atoms with the same charge#105
Open
lorenzo-22 wants to merge 4 commits intomasterfrom
Open
fixing interactions between atoms with the same charge#105lorenzo-22 wants to merge 4 commits intomasterfrom
lorenzo-22 wants to merge 4 commits intomasterfrom
Conversation
mtiberti
requested changes
Mar 12, 2025
Collaborator
mtiberti
left a comment
There was a problem hiding this comment.
not much to review here :) cool that this was a small fix!
however, would you add a test to the dataset for same-charge interactions?
this means
- generating reference data in
tests/dataof same-charge interactions - modifying
test_libinteract.pyso that a test on same-charge interactions is performed you can check e.g.test_do_sband the objects/functions called there to see how this is done
besides, have you run the tests after you did your fix?
added files for test
modified test_libinteract.py so that a test on same-charge interactions is performed
mtiberti
requested changes
Mar 24, 2025
Collaborator
mtiberti
left a comment
There was a problem hiding this comment.
can we change the file name of the data file to something that makes it clear that these are same-charge interactions? I also don't think these should be called salt_bridge since they are not salt bridges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #64 fixing interactions between atoms with the same charge by changing how "sets_sizes" list is created.