Tags: EdgeJ/code-generator
Tags
Update to ACK runtime `v0.15.2` (aws-controllers-k8s#234) Description of changes: Update the ACK runtime to version `v0.15.2` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Update to ACK runtime `v0.15.1` (aws-controllers-k8s#219) Description of changes: Updates the ACK runtime to `v0.15.1` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Update to ACK runtime `v0.15.0` (aws-controllers-k8s#217) Description of changes: Update the runtime to version `v0.15.0` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Update ACK runtime to v0.14.1 (aws-controllers-k8s#205) Description of changes: Update ACK runtime to v0.14.1 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Update to ACK runtime `v0.14.0` (aws-controllers-k8s#194) Description of changes: Upgrade to ACK runtime `v0.14.0` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fix installation of controller-gen in prowjobs (aws-controllers-k8s#187) Issue #, if available: Description of changes: * Fix installation of controller-gen in prowjobs * Installing controller-gen in prowjobs fail because $GOPATH/bin directory is not present. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
aws-controllers-k8s/runtime update from v0.13.0 to v0.13.1 (aws-contr… …ollers-k8s#181) Issue #, if available: aws-controllers-k8s/community#894 Description of changes: * aws-controllers-k8s/runtime update from v0.13.0 to v0.13.1 * no interface changes * ran `go.mod.tidy` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Bug fixes for status patching and late initialization patching (aws-c… …ontrollers-k8s#168) Description of changes: Commit#1 - Adds the implementation of AWSResource.DeepCopy() method. aws-controllers-k8s/runtime#48 Commit#2 - Fixes the patching bug in lateInitialize code to unblock sagemaker team - BUG: rm.LateInitialize() method was adding lateInitialized fields to the same object passed in the parameter and returning as output. ```go lateInitializedLatest, err := rm.LateInitialize(ctx, latest) rlog.Exit("rm.LateInitialize", err) // Always patch after late initialize because some fields may have been initialized while // others require a retry after some delay. // This patching does not hurt because if there is no diff then 'patchResourceMetadataAndSpec' // acts as a no-op. if ackcompare.IsNotNil(lateInitializedLatest) { patchErr := r.patchResourceMetadataAndSpec(ctx, latest, lateInitializedLatest) // Throw the patching error if reconciler is unable to patch the resource with late initializations if patchErr != nil { err = patchErr } } ``` - Since lateInitializedLatest and latest were same object, above `patchResourceMetadataAndSpec` call sees no diff and does not patch lateInitialized fields into etcd. - This PR solves the bug by adding lateInitialized fields in a copy of latest and returning that copy (without modifying latest) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Update to ACK runtime `v0.12.0` (aws-controllers-k8s#158) Update the dependent version of ACK runtime to `v0.12.0` and update the `ackgenerate` version
Implement ReadMany for CheckRequiredFieldsMissingFromShape (aws-contr… …ollers-k8s#155) Issue #, if available: [#890](aws-controllers-k8s/community#890) Description of changes: * Adds checkRequiredFieldsMissingFromShapeReadMany to `check.go` to handle ReadMany operations without a corresponding ReadOne. * The new method will **require resource identifier field** should there exist an *identifier* or *identifierS* field in the ReadMany operation. * Eventually `newListRequestPayload` will use this identifier field to populate its request in order to guarantee the ReadMany operation returns the desired resource. * ex: DescribeVpcs has a VpcIds field. Therefore, Vpc shape should require VpcId, which is part of its status field. * Updated tests and templates Testing: * `make test` ✅ * `make build-controller` ✅ ``` func (rm *resourceManager) sdkFind( ctx context.Context, r *resource, ) (latest *resource, err error) { rlog := ackrtlog.FromContext(ctx) exit := rlog.Trace("rm.sdkFind") defer exit(err) // If any required fields in the input shape are missing, AWS resource is // not created yet. Return NotFound here to indicate to callers that the // resource isn't yet created. if rm.requiredFieldsMissingFromReadManyInput(r) { return nil, ackerr.NotFound } input, err := rm.newListRequestPayload(r) ... // requiredFieldsMissingFromReadManyInput returns true if there are any fields // for the ReadMany Input shape that are required but not present in the // resource's Spec or Status func (rm *resourceManager) requiredFieldsMissingFromReadManyInput( r *resource, ) bool { return r.ko.Status.VPCID == nil } ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
PreviousNext