Open
Conversation
kelichiu
approved these changes
Mar 2, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Complete
Code Execution
All code cells execute without errors.
Code Quality
Code is well-organized, concise, and includes necessary comments for clarity.
Data Handling
Data files are correctly handled and processed.
Adherence to Instructions
Follows all instructions and requirements as per the assignment.
Specific Criteria
- Reading in our files
Correctly prints out information from the first file. - Summarizing our data
Correctly defines patient_summary() function. Function processes data as per operation and outputs correctly shaped data (60 entries). - Checking for Errors
Correctly defines detect_problems() function. Function uses patient_summary() and check_zeros() to identify mean inflammation of 0 accurately.
Overall Assessment
Meets all the general and specific criteria, indicating a strong understanding of the assignment objectives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Using the code base provided in the assignment, I produced several functions that could process patient datasets in order to investigate the effectiveness of a fictional medication to treat arthritis. The functions I modified can do the following: read patient data contained within a .csv file and print it to the screen for visual examination, calculate summary statistics on patient data and check patient data for potential errors/outliers.
What did you learn from the changes you have made?
I learned how to read and work with .csv files in python and how to incorporate functions from packages such as numpy into my coding scripts.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
For the first prompt of the assignment, I considered using readline() as opposed to readlines() when saving the data from a .csv file to a variable. Ultimately, I decided that readlines() would require less steps and create a variable that was easier to iterate through.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I did not face any major challenges in this assignment. One thing that took me a little while to understand was how to incorporate the check_zeros() function into the detect_problems() function. At first I thought that an if/else statement was required to tell detect_problems() what to return, but then I realized that you could just return the output of check_zeros().
How were these changes tested?
I ran the provided coding checks to ensure I obtained the expected values. I also created my own checks to confirm that the patient_summary() function was working as it should for all summary statistics and that the detect_problems() function could in fact detect rows that had a mean of zero as the dataset we looked at had no such rows.
A reference to a related issue in your repository (if applicable)
NA
Checklist