Skip to content

UofT-DSI | python - Assignment 2#2

Open
Ellenski wants to merge 1 commit intomainfrom
assignment-2
Open

UofT-DSI | python - Assignment 2#2
Ellenski wants to merge 1 commit intomainfrom
assignment-2

Conversation

@Ellenski
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Using the code base provided in the assignment, I produced several functions that could process patient datasets in order to investigate the effectiveness of a fictional medication to treat arthritis. The functions I modified can do the following: read patient data contained within a .csv file and print it to the screen for visual examination, calculate summary statistics on patient data and check patient data for potential errors/outliers.

What did you learn from the changes you have made?

I learned how to read and work with .csv files in python and how to incorporate functions from packages such as numpy into my coding scripts.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

For the first prompt of the assignment, I considered using readline() as opposed to readlines() when saving the data from a .csv file to a variable. Ultimately, I decided that readlines() would require less steps and create a variable that was easier to iterate through.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I did not face any major challenges in this assignment. One thing that took me a little while to understand was how to incorporate the check_zeros() function into the detect_problems() function. At first I thought that an if/else statement was required to tell detect_problems() what to return, but then I realized that you could just return the output of check_zeros().

How were these changes tested?

I ran the provided coding checks to ensure I obtained the expected values. I also created my own checks to confirm that the patient_summary() function was working as it should for all summary statistics and that the detect_problems() function could in fact detect rows that had a mean of zero as the dataset we looked at had no such rows.

A reference to a related issue in your repository (if applicable)

NA

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@kelichiu kelichiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete

Code Execution

All code cells execute without errors.

Code Quality

Code is well-organized, concise, and includes necessary comments for clarity.

Data Handling

Data files are correctly handled and processed.

Adherence to Instructions

Follows all instructions and requirements as per the assignment.

Specific Criteria

  1. Reading in our files
    Correctly prints out information from the first file.
  2. Summarizing our data
    Correctly defines patient_summary() function. Function processes data as per operation and outputs correctly shaped data (60 entries).
  3. Checking for Errors
    Correctly defines detect_problems() function. Function uses patient_summary() and check_zeros() to identify mean inflammation of 0 accurately.

Overall Assessment

Meets all the general and specific criteria, indicating a strong understanding of the assignment objectives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants