How will this affect usage with our windows plugins ? I am talking about the "window should close" methods
Have you tested it ?

How will this affect usage with our windows plugins ? I am talking about the "window should close" methods Have you tested it ?

Please provide an example like this

Since I tested it from the current Raylib implementation of the GameDemo, the windows plugins should works the same way.

As an example, the current implementation let the user define a new system to handle whenever the window should close like this:

core.RegisterSystem<ES::Engine::Scheduler::RelativeTimeUpdate>(Game::RunLoop);

This system being as simple as this:

void Game::RunLoop(ES::Engine::Core &core)
{
    if (Raylib::WindowShouldClose())
        core.Stop();
}

We can simply call the runCore function now to run the systems. This avoids having to write a loop condition outside of the core to handle their execution, but inside as systems:

core.RunCore();

Since I tested it from the current Raylib implementation of the GameDemo, the windows plugins should works the same way.

As an example, the current implementation let the user define a new system to handle whenever the window should close like this:

core.RegisterSystem<ES::Engine::Scheduler::RelativeTimeUpdate>(Game::RunLoop);

This system being as simple as this:

void Game::RunLoop(ES::Engine::Core &core)
{
    if (Raylib::WindowShouldClose())
        core.Stop();
}

We can simply call the runCore function now to run the systems. This avoids having to write a loop condition outside of the core to handle their execution, but inside as systems:

core.RunCore();

Okay, fix conflicts and it's good

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud