Conversation
…ndow' of github.com:EngineSquared/EngineSquared into 119-use-the-window-plugin-instead-of-the-wrapper-glfwwindow
ripel2
suggested changes
Mar 20, 2025
Contributor
ripel2
left a comment
There was a problem hiding this comment.
naming the new window resource "ESQWindow" is redundant because we are already inside ESQ
Contributor
|
also, why is the previous glfwwindow still here ? |
…ndow' of github.com:EngineSquared/EngineSquared into 119-use-the-window-plugin-instead-of-the-wrapper-glfwwindow
Contributor
|
just fix the sonar error and it will be good @Miou-zora @MasterLaplace |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to:
You can test it on https://github.com/Miou-zora/ESGL-Example/tree/esq-pr-136