Conversation
Closed
Contributor
Author
|
|
Contributor
Author
done |
Miou-zora
requested changes
Mar 26, 2025
| explicit Font(const std::string &fontPath, int fontSize); | ||
| ~Font() = default; | ||
|
|
||
| void RenderText(const std::string &text, float x, float y, float scale, GLuint VAO, GLuint VBO) const; |
Contributor
There was a problem hiding this comment.
It feels strange to have this method inside a font class that should maybe only store data
Contributor
Author
There was a problem hiding this comment.
a lot of our utils classes have methods inside so it should be okay, I could rewrite it inside the gltextbuffer but it would be a spaghetti
Contributor
Author
There was a problem hiding this comment.
okay, I made it in the buffer instead and it is cleaner, please look at it
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Miou-zora
approved these changes
Mar 26, 2025
MasterLaplace
pushed a commit
that referenced
this pull request
Mar 29, 2025
Related to: - #38  Can be tested on [OpenGL-Example/text-rendering](https://github.com/EngineSquared/OpenGL-Example/tree/text-rendering) Notes: - Font paths are relative to the project, system-wide fonts are not supported (there are different APIs for each platform, should be done in a new issue) - The text component contains too much information but we are lacking components for 2D transforms - Kerning is hard to get right so it is not implemented for now --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
Can be tested on OpenGL-Example/text-rendering
Notes: