Skip to content

feat(physics): softbody integration#156

Merged
ripel2 merged 20 commits intomainfrom
jolt-soft-body
Apr 2, 2025
Merged

feat(physics): softbody integration#156
ripel2 merged 20 commits intomainfrom
jolt-soft-body

Conversation

@ripel2
Copy link
Contributor

@ripel2 ripel2 commented Apr 1, 2025 •
edited
Loading

Related to no issues (it was supposed to be in #154)

Notes:

  • I fixed a bug in the Physics plugin: previously it used the deltaTime of RelativeTimeUpdate but the systems themselves didn't use this scheduler
  • FixedTimeUpdate is used instead of RelativeTimeUpdate, otherwise the simulation is not deterministic
  • Transform scaling is not supported

(We should bump the default rate of the FixedTimeUpdate to something higher)

@ripel2 ripel2 added the enhancement New feature or request label Apr 1, 2025
@ripel2 ripel2 requested a review from a team April 1, 2025 06:44
@ripel2 ripel2 self-assigned this Apr 1, 2025
@ripel2 ripel2 marked this pull request as ready for review April 1, 2025 08:30
MasterLaplace
MasterLaplace previously approved these changes Apr 1, 2025
View reviewed changes
@ripel2 ripel2 enabled auto-merge (squash) April 1, 2025 11:50
@ripel2 ripel2 requested review from a team and MasterLaplace and removed request for MasterLaplace April 1, 2025 11:59
MasterLaplace
MasterLaplace suggested changes Apr 1, 2025
View reviewed changes
@ripel2 ripel2 requested a review from Copilot April 1, 2025 14:06
Copilot AI reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (7)
  • src/plugin/physics/src/JoltPhysics.hpp: Language not supported
  • src/plugin/physics/src/component/SoftBody3D.hpp: Language not supported
  • src/plugin/physics/src/plugin/PluginPhysics.cpp: Language not supported
  • src/plugin/physics/src/system/PhysicsUpdate.cpp: Language not supported
  • src/plugin/physics/src/system/PhysicsUpdate.hpp: Language not supported
  • src/plugin/physics/src/utils/SoftBodyCreationSettings.hpp: Language not supported
  • src/plugin/physics/src/utils/SoftBodyVertexSettings.hpp: Language not supported

@ripel2 ripel2 requested a review from MasterLaplace April 2, 2025 06:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ripel2 ripel2 merged commit ddab79e into main Apr 2, 2025
11 checks passed
@ripel2 ripel2 deleted the jolt-soft-body branch April 2, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@MasterLaplace MasterLaplace MasterLaplace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ripel2 ripel2

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ripel2 @MasterLaplace