feat: make the project "Packaging compliant"#268
Merged
Conversation
…d into webgpu_plugin
|
ripel2
approved these changes
Sep 7, 2025
ripel2
approved these changes
Sep 7, 2025
Divengerss
approved these changes
Sep 8, 2025
MasterLaplace
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related to no issue.
This PR makes the code more cleaner and make it compliant for packaging.
"Quick" note on what changed:
src. E.g.: the filesrc/core/Core.hppneeds to be included as#include "core/Core.hpp"orsrc/resource/window/Window.hppas#include "resource/window/Window.hpp"add_includedirsbecause we want to use include like in package, so one at the root of the plugin/util. That's the reason why we now needs to include the path aftersrcfolder.add_headerfilesare added to sync local build and package build. So to include a file in a new folder of plugin/util you need to add something likeadd_headerfiles("src/(the/path/of/the/file/*.hpp)")(don't forget.inltoo)set_policy,add_rules,add_requires(important)set_languages("c++20"),set_warnings("allextra")(this will uniform warnings along all target),add_rules("plugin.compile_commands.autoupdate", {outputdir = ".vscode"})(each times you will try to compile, it will generate acompile_commands.json, useful for linter)InputManager::IsKeyPressed,Window::SetResizablem_lastDesiredor_decoderImportant
Don't use
**.extinadd_headerfiles, it can cause some errors in package. E.g.: usingadd_headerfiles("src/(foo/**.hpp)")forsrc/foo/bar/file.hppwill createfoo/file.hppinclude file in package which is something different than expected (foo/bar/file.hpp)Note
Even If the branch seems to be related to webgpu, there is no webgpu related modifications, I just started with it to make it easier for me to debug/test it.