Skip to content

ci: automatic commit norm verification#31

Merged
ripel2 merged 4 commits intomainfrom
28-commit-norm
Oct 15, 2024
Merged

ci: automatic commit norm verification#31
ripel2 merged 4 commits intomainfrom
28-commit-norm

Conversation

@MasterLaplace
Copy link
Contributor

@MasterLaplace MasterLaplace commented Oct 15, 2024

Right now we are using Angular's commit norm to have normalized commit messages but this should be visible to every contributor (especially new ones)

  • check the commit norm on pull requests (with CI)
  • respect Angular's commit norm

Partially linked to:

Add a new GitHub Actions workflow file, commit_norm_check.yml, to enforce commit message format. The workflow checks if the commit message matches the expected format "keyword(scope): comment". If the commit message does not match the format, it displays an error message and exits with a non-zero status code.
@MasterLaplace MasterLaplace added the ci Everything related to continous integration label Oct 15, 2024
@MasterLaplace MasterLaplace requested a review from ripel2 October 15, 2024 01:02
@MasterLaplace MasterLaplace self-assigned this Oct 15, 2024
@MasterLaplace MasterLaplace linked an issue Oct 15, 2024 that may be closed by this pull request
@MasterLaplace MasterLaplace added this to the First follow-up milestone Oct 15, 2024
@MasterLaplace MasterLaplace removed a link to an issue Oct 15, 2024
@MasterLaplace MasterLaplace linked an issue Oct 15, 2024 that may be closed by this pull request
@ripel2 ripel2 changed the title 28 commit norm ci: automatic commit norm verification Oct 15, 2024
@ripel2
Copy link
Contributor

ripel2 commented Oct 15, 2024

also please link your pull request to an issue @MasterLaplace

@MasterLaplace MasterLaplace requested a review from ripel2 October 15, 2024 08:36
@MasterLaplace
Copy link
Contributor Author

also please link your pull request to an issue @MasterLaplace

I'd already established a link, hadn't I?

@ripel2 ripel2 merged commit 3979f19 into main Oct 15, 2024
@ripel2 ripel2 deleted the 28-commit-norm branch October 15, 2024 08:46
@ripel2
Copy link
Contributor

ripel2 commented Oct 15, 2024

also please link your pull request to an issue @MasterLaplace

I'd already established a link, hadn't I?

i did it for you before merging ;)

@ripel2
Copy link
Contributor

ripel2 commented Oct 15, 2024

also please link your pull request to an issue @MasterLaplace

I'd already established a link, hadn't I?

i did it for you before merging ;)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Everything related to continous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit norm

2 participants