feat(Registry): add fixed update system management#63
Merged
Conversation
…gineSquared into 61-fixed-update
Closed
ripel2
reviewed
Nov 25, 2024
Contributor
ripel2
left a comment
There was a problem hiding this comment.
I think it would be great to discuss about making the DeltaTime handling more coherent
Because right now we can have it directly in the registry for FixedDeltaTime but for RealTime we need to create and use a resource. Why should we create a resource for one and not the other ?
Contributor
|
Also, when testing with the SB-Test-Scene, the systems do not run if the framerate is over 50FPS. Here is how I did it, maybe I did something wrong
|
Contributor
|
Putting this PR in draft while we discuss it |
|
Contributor
|
The bug of the systems not running is fixed |
ripel2
approved these changes
Nov 26, 2024
MasterLaplace
pushed a commit
that referenced
this pull request
Dec 6, 2024
I've added a way to add systems that will be added each specified ticks (50 per seconds per default). These systems should call `Registry::GetFixedDeltaTime` to get delta time rather than `RealTimeProvider` resource. I've also added a `Clock` that can be used as a clock to have specific tickrate. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a way to add systems that will be added each specified ticks (50 per seconds per default). These systems should call
Registry::GetFixedDeltaTimeto get delta time rather thanRealTimeProviderresource. I've also added aClockthat can be used as a clock to have specific tickrate.