Skip to content

feat(object): obj loader#72

Merged
ripel2 merged 28 commits intomainfrom
40-obj-loader
Dec 16, 2024
Merged

feat(object): obj loader#72
ripel2 merged 28 commits intomainfrom
40-obj-loader

Conversation

@MasterLaplace
Copy link
Contributor

@MasterLaplace MasterLaplace commented Dec 9, 2024 •
edited
Loading

Related to:

In short:

  • a vertex component to be used by the Vk-Wrapper, which stores the position of the points, the colour of each point and the texture coordinate
  • a mesh component that will also be used by the Vk-Wrapper, which stores the model's vertices and indices.
  • a MeshLoader to test the management of entt resources (optional)
  • OBJLoader is used to load models

All the classes have been tested and are working.

@MasterLaplace MasterLaplace added enhancement New feature or request test Additions or modifications to tests labels Dec 9, 2024
@MasterLaplace MasterLaplace self-assigned this Dec 9, 2024
@MasterLaplace MasterLaplace linked an issue Dec 9, 2024 that may be closed by this pull request
OBJ Loader #40
Closed
3 tasks
MasterLaplace and others added 20 commits December 9, 2024 05:51
@MasterLaplace
feat(object): add the declaration of the Vertex structure to represen…
f0986b8 
…t a vertex in a mesh
@MasterLaplace
feat(object): add the declaration of the Mesh structure to represent …
0e8a84f 
…a mesh
@MasterLaplace
feat(object): implement OBJLoader for loading .obj files and managing…
cda8f50 
… vertices and indices
@MasterLaplace
feat(object): add inclusions for OBJLoader, Vertex, and Mesh in Objec…
b372439 
…t.hpp
@MasterLaplace
feat(object): add validation for model loading path in OBJLoader
d50f517
@MasterLaplace
feat(object): reorder includes in Object.hpp and add unit tests for O…
6b6612f 
…BJLoader
@github-actions @MasterLaplace
style: apply linter
054a214
@MasterLaplace
feat(tests): add .obj files for model loading tests
eed6e74
@MasterLaplace
fix(object): move TINYOBJLOADER_IMPLEMENTATION to OBJLoader.cpp and u…
edbba8a 
…pdate dependencies
@MasterLaplace
fix(tests): update OBJLoader tests to use a defined file path for assets
da879eb
@github-actions @MasterLaplace
style: apply linter
5a04226
@MasterLaplace
fix(object): refactor OBJLoader to include Logger and change target k…
d0f16f1 
…ind to static
@MasterLaplace
fix(tests): update OBJLoader tests to use a new asset path and adjust…
e22afdd 
… file loading
@MasterLaplace
fix(build): update asset handling in xmake.lua for improved build pro…
b3c22c4 
…cess
@MasterLaplace
fix(tests): remove obsolete loadModel_fail test and associated asset
727892a
@MasterLaplace
fix(build): remove obsolete test target configuration from xmake.lua
de8e13a
@MasterLaplace
fix(tests): add assertions to verify vertices and indices are not emp…
0e6d7ca 
…ty in loadModel test
@MasterLaplace
refactor(mesh): update MeshLoader to use a functor for loading meshes
d85e575
@MasterLaplace
test(mesh): add unit test for loading mesh from entt resource cache
f26bf0c
@MasterLaplace
test(vertex): add unit tests for the Vertex structure
36b6fb0
@MasterLaplace MasterLaplace marked this pull request as draft December 9, 2024 10:56
@MasterLaplace MasterLaplace marked this pull request as ready for review December 10, 2024 05:43
@MasterLaplace MasterLaplace requested review from a team and removed request for Miou-zora December 10, 2024 05:43
@ripel2 ripel2 changed the title Obj loader and Entt Cache Loader test feat(vk-wrapper): obj loader and entt cache loader test Dec 15, 2024
ripel2
ripel2 reviewed Dec 15, 2024
View reviewed changes
@ripel2 ripel2 changed the title feat(vk-wrapper): obj loader and entt cache loader test feat(object): obj loader Dec 15, 2024
@MasterLaplace MasterLaplace requested a review from ripel2 December 15, 2024 20:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ripel2 ripel2 merged commit 9270b8e into main Dec 16, 2024
@ripel2 ripel2 deleted the 40-obj-loader branch December 16, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ripel2 ripel2 ripel2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MasterLaplace MasterLaplace

Labels

enhancement New feature or request test Additions or modifications to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OBJ Loader

2 participants

@MasterLaplace @ripel2