Skip to content

feat(Entity): add a ctor with Entity#97

Merged
Miou-zora merged 3 commits intomainfrom
add-Entity-with-Entity-ctor
Mar 2, 2025
Merged

feat(Entity): add a ctor with Entity#97
Miou-zora merged 3 commits intomainfrom
add-Entity-with-Entity-ctor

Conversation

@Miou-zora
Copy link
Contributor

Not linked to any issue.

Currently when we want to create a new empty Entity, we need to transform entity_null_id to entt::entity and use it. It will force us to init entity like this:

ES::Engine::Entity new_entity(ES::Engine::Entity::ToEnttEntity(ES::Engine::Entity::entity_null_id))

Which is so fucking unconvenient :/

This PR allows to init entity like this:

ES::Engine::Entity new_entity;

@Miou-zora Miou-zora added the enhancement New feature or request label Feb 24, 2025
@Miou-zora Miou-zora requested a review from a team February 24, 2025 12:17
@Miou-zora Miou-zora self-assigned this Feb 24, 2025
ripel2
ripel2 previously approved these changes Feb 26, 2025
Copy link
Contributor

@ripel2 ripel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@Miou-zora Miou-zora merged commit 472f96d into main Mar 2, 2025
10 checks passed
@Miou-zora Miou-zora deleted the add-Entity-with-Entity-ctor branch March 2, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants