Support providing root_certificates for TLS connections#26
Support providing root_certificates for TLS connections#26oyvindwe merged 3 commits intoExabel:mainfrom
Conversation
oyvindwe
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @HaakonHam)
exabel_data_sdk/client/client_config.py, line 42 at r1 (raw file):
port: Exabel API port. timeout: Default timeout in seconds to use for API requests. root_certificates: Root certificates to use.
Rephrase: Additional allowed root certificates for verifying TLS connection
exabel_data_sdk/client/exabel_client.py, line 34 at r1 (raw file):
port: Override default Exabel API port. timeout: Override default timeout in seconds to use for API requests. root_certificates: Root certificates to use.
Rephrase: Additional allowed root certificates for verifying TLS connection
oyvindwe
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
exabel_data_sdk/client/client_config.py, line 42 at r1 (raw file):
Previously, oyvindwe (Øyvind Matheson Wergeland) wrote…
Rephrase:
Additional allowed root certificates for verifying TLS connection
OK.
exabel_data_sdk/client/exabel_client.py, line 34 at r1 (raw file):
Previously, oyvindwe (Øyvind Matheson Wergeland) wrote…
Rephrase:
Additional allowed root certificates for verifying TLS connection
OK.
taral
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:
This change is