Skip to content

Return None instead of raising error for NotFound#31

Merged
hallarak merged 2 commits intoExabel:mainfrom
hallarak:return_none_for_not_found
Jul 2, 2021
Merged

Return None instead of raising error for NotFound#31
hallarak merged 2 commits intoExabel:mainfrom
hallarak:return_none_for_not_found

Conversation

@hallarak
Copy link
Copy Markdown
Contributor

@hallarak hallarak commented Jul 2, 2021

This change is Reviewable

@hallarak hallarak requested a review from taral July 2, 2021 11:41
@hallarak
Copy link
Copy Markdown
Contributor Author

hallarak commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

@taral taral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to publish this right away, you should increment the version in setup.py.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor

@taral taral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@hallarak hallarak merged commit 0691a51 into Exabel:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants