Skip to content

Fixed common tags leaking state between spans #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashishagg merged 2 commits into from
Jan 29, 2020
Merged

Fixed common tags leaking state between spans #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80d7087
fix bug where state is leaked between spans when using common tags fe…
Jan 28, 2020
56a3f2f
fix linting issue
Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion haystack/tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ def start_span(self,

# Set common tags
if self._common_tags:
tags = {**self._common_tags, **tags} if tags else self._common_tags
tags = {**self._common_tags, **tags} if tags else \
self._common_tags.copy()

return Span(self,
operation_name=operation_name,
Expand Down