Add guard around DEVICE_NAME for common headers#1147
Add guard around DEVICE_NAME for common headers#1147pkendall64 merged 4 commits intoExpressLRS:2.0.x-maintenancefrom
Conversation
Add missing options to mDNS options string
|
I am encountering an error when trying to build DIY_2400_TX_ESP32_SX1280_E28 with the user define -DDEVICE_NAME="Test_Name"
DEVICE_NAME on the mDNS record has 2 sets of double quotes surrounding it
What do you think about device name being its own entry on the mDNS record, like version and target? |
|
I added guards for the BetaFPV RX/TX because those are used by JHEMCU / HiYounger according to #1139. However, these RXes cloned the BetaFPV layout and didn't include all the parts, so they're missing (among other things) the inductor for the DCDC converter on the SX1280. I believe they should still work, at least they do when I tried it with an EP2 that doesn't have the inductor, but I am not sure how safe it is to enable the DCDC if it isn't connected. Does this make my desire for target aliases a pipe dream? |
Everywhere in the code can use the same string now.
|
I added guards around the rest of the targets DEVICE_NAME defines. |
CapnBry
left a comment
There was a problem hiding this comment.
Now everyone can even make their own device names for any device! I'mma name all mine SIXTEEN characters long. I like that you moved device_name to the options like the other strings. Typical, pkendall64-grade excellent work.
Add
DEVICE_NAMEto mDNS options string so configurator can use this to match alias for a target.Also, adds other missing options to mDNS options string.