Move 5115's logo to the logo folder because Brian is stupid.#4
Merged
ErikBoesen merged 1 commit intoFIRSTMap:masterfrom Aug 20, 2016
cruzsbrian:master
Merged
Move 5115's logo to the logo folder because Brian is stupid.#4ErikBoesen merged 1 commit intoFIRSTMap:masterfrom cruzsbrian:master
ErikBoesen merged 1 commit intoFIRSTMap:masterfrom
cruzsbrian:master
Conversation
Member
|
Yeah, that would be the issue. |
Contributor
Author
|
Maybe you/we ought to normalize the size of the logos. |
Member
|
I realized I forgot to include that in the README. They should be a maximum of 38px wide or tall. Would you like to add that? |
Contributor
Author
|
Um, I can't right now, but I will if you don't. Want to add me as a contributor? |
Member
|
I can do it now, that's fine. It's not that I don't trust you, but I generally only make people contributors who have done a very significant portion of the work. So not yet. You're welcome to keep doing pull requests. |
Contributor
Author
|
OK. That's reasonable. |
Member
|
Again, no disrespect to you. I've been looking at your GitHub and the work you do looks incredible, so don't worry about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.