Skip to content

MotorEx Calls Super At Constructor#113

Merged
puravdatta-sudo merged 3 commits intomasterfrom
hotfix-MotorEx
Nov 8, 2020
Merged

MotorEx Calls Super At Constructor#113
puravdatta-sudo merged 3 commits intomasterfrom
hotfix-MotorEx

Conversation

@JIceberg
Copy link
Copy Markdown
Member

@JIceberg JIceberg commented Nov 7, 2020

MotorEx Calls Super At Constructor

What kind of change does this PR introduce?

Did this PR introduce a breaking change?

  • No

Please make sure your PR satisfies the requirements of the contributing page

Signed-off-by: JIceberg <[email protected]>
@JIceberg
Copy link
Copy Markdown
Member Author

JIceberg commented Nov 7, 2020

I think the issue was something with Java inheritance and the way classes and subclasses are related. I'm hoping that by calling super() in the constructor and auto-instantiating the controllers (that way it's literally impossible for that NPE to be thrown), these issues will be resolved.

Copy link
Copy Markdown
Member

@puravdatta-sudo puravdatta-sudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright looks good, seems like it would fix a lot of problems.

@puravdatta-sudo puravdatta-sudo merged commit a682db0 into master Nov 8, 2020
@puravdatta-sudo puravdatta-sudo deleted the hotfix-MotorEx branch November 8, 2020 00:40
@Aman-Anas
Copy link
Copy Markdown

this saved our sanity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AnubhavParida (PIDFController.reset() on a null obj reference)

3 participants