Open
Conversation
Contributor
|
What the |
Jaiming724
reviewed
May 26, 2021
| * @param onEnd the action to run after the time period is up | ||
| * @param milliseconds the wait time | ||
| */ | ||
| public TimedAction(Runnable onRun, Runnable onEnd, double milliseconds) { |
Contributor
There was a problem hiding this comment.
Add a constructor that just has onRun and milisecond since I do not think many people will require both.
Member
Author
There was a problem hiding this comment.
A lot of people use both for things like a flicker. Having just an onRun will not really do anything for them, I guess either? That's just the same as changing it. The goal here is to perform some action for milliseconds milliseconds and then perform some onEnd action.
| flickerServo = new SimpleServo(hardwareMap, "flicker", 0, 270); | ||
| // for this example, 35 degrees is the resting position and 80 degrees is the flick out position | ||
| flicker = new TimedAction( | ||
| () -> flickerServo.turnToAngle(80), |
Contributor
There was a problem hiding this comment.
Replace one of the lambda with an anonymous class and explain how both of them work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#170