Fix Typo in PIDFController That Breaks I-Term Total Error#188
Merged
Fix Typo in PIDFController That Breaks I-Term Total Error#188
PIDFController That Breaks I-Term Total Error#188Conversation
JarnaChao09
approved these changes
Sep 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Typo in
PIDFControllerThat Breaks I-Term Total ErrorPlease note that we accept pull requests from anyone, but that does not mean it will be merged.
What kind of change does this PR introduce?
Fix -- Fixes a typi in the PIDF controller that made
totalErrornot accumulate error over time.Did this PR introduce a breaking change?
No
Please make sure your PR satisfies the requirements of the contributing page